kfaraz commented on code in PR #18699:
URL: https://github.com/apache/druid/pull/18699#discussion_r2469236072
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -107,6 +107,7 @@ public class AsyncQueryForwardingServlet extends
AsyncProxyServlet implements Qu
private static final String PROPERTY_SQL_ENABLE_DEFAULT = "false";
private static final long CANCELLATION_TIMEOUT_MILLIS =
TimeUnit.SECONDS.toMillis(5);
+ private static final int UNASSIGNED_DEFAULT_STATUS_CODE = 0; //
Jetty-specific default (un-assigned) status code
Review Comment:
```suggestion
// Jetty-specific default (un-assigned) status code
private static final int UNASSIGNED_DEFAULT_STATUS_CODE = 0;
```
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -857,8 +858,9 @@ public void onFailure(Response response, Throwable failure)
failedQueryCount.incrementAndGet();
// As router is simply a proxy, we don't make an effort to construct the
error code from the exception ourselves.
- // We rely on broker to set this for us if the error occurs downstream.
- emitQueryTime(requestTimeNs, false, sqlQueryId, queryId,
response.getStatus());
+ // We rely on broker to set this for us if the error occurs downstream.
Otherwise, if there's a router/client error, we log this as an ISE.
Review Comment:
ISE might be confused with the Druid `ISE` (flavor of IllegalStateException).
```suggestion
// We rely on broker to set this for us if the error occurs downstream.
// Otherwise, if there's a router/client error, we log this as an
unknown error.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
