clintropolis commented on code in PR #18742: URL: https://github.com/apache/druid/pull/18742#discussion_r2537397953
########## server/src/main/java/org/apache/druid/segment/loading/VirtualStorageLocationStats.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.loading; + +public interface VirtualStorageLocationStats Review Comment: they don't quite line up, there is not an explicit 'drop' in virtual storage, instead they are always evicted when something else needs the space, so i had them separate so the names are clearer to their function. I also didn't see a lot of usefulness in them being the same type, since they don't emit the same metrics, the only thing they both have in common is a location dimension and loads. I guess later when load rules would allow mixed usage of disk it might be nice to have one object per location, but it would also need to distinguish static loads from virtual loads, so need to think about it a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
