kfaraz commented on code in PR #18805:
URL: https://github.com/apache/druid/pull/18805#discussion_r2588216630
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/SystemTableQueryTest.java:
##########
@@ -66,10 +53,9 @@ public void testSystemTableQueries_segmentsCount()
dataSourceName1, dataSourceName2
);
- String[] result = cluster.callApi().runSql(query).split("\n");
- Assertions.assertEquals(2, result.length);
- Assertions.assertEquals(StringUtils.format("%s,10", dataSourceName1),
result[0]);
- Assertions.assertEquals(StringUtils.format("%s,10", dataSourceName2),
result[1]);
+ String result = cluster.callApi().runSql(query);
+ Assertions.assertTrue(result.contains(dataSourceName1));
Review Comment:
This assertion doesn't really verify the count (as the test name suggests).
I think we can get rid of the `dataSourceName2` and just use
`dataSourceName1` to simplify this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
