capistrant commented on code in PR #18599: URL: https://github.com/apache/druid/pull/18599#discussion_r2599581635
########## extensions-core/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/common/TestCachingKubernetesClient.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.k8s.overlord.common; + +public class TestCachingKubernetesClient extends DruidKubernetesCachingClient +{ + private static final long TESTING_RESYNC_PERIOD_MS = 10L; + + public TestCachingKubernetesClient(KubernetesClientApi clientApi, String namespace) + { + super(clientApi, namespace, TESTING_RESYNC_PERIOD_MS); + } + + public void start() Review Comment: but I guess this does mean that we are probably eagerly starting informers for both the standby and leader overlord. Is this okay or do we need becoming leader code to be what creates the informers? it would slow down failovers since the initial sync has to list all pods to build the initial cache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
