abhishekrb19 commented on code in PR #18850:
URL: https://github.com/apache/druid/pull/18850#discussion_r2628726466
##########
processing/src/main/java/org/apache/druid/segment/serde/NestedCommonFormatColumnPartSerde.java:
##########
@@ -482,8 +482,8 @@ public FormatSpec(
@JsonProperty("longColumnCompression")@Nullable CompressionStrategy
longColumnCompression,
@JsonProperty("doubleColumnCompression")@Nullable CompressionStrategy
doubleColumnCompression,
@JsonProperty("bitmapEncoding") @Nullable BitmapSerdeFactory
bitmapEncoding,
- @JsonProperty("longFieldBitmapIndex")@Nullable BitmapIndexType
longFieldBitmapIndex,
- @JsonProperty("doubleFieldBitmapIndex")@Nullable BitmapIndexType
doubleFieldBitmapIndex
+ @JsonProperty("longFieldBitmapIndexType")@Nullable BitmapIndexType
longFieldBitmapIndex,
+ @JsonProperty("doubleFieldBitmapIndexType")@Nullable BitmapIndexType
doubleFieldBitmapIndex
Review Comment:
Should we also rename these fields to align with the json property name and
stuff that's defined in the underlying spec
`NestedCommonFormatColumnFormatSpec`:
- longFieldBitmapIndex -> longFieldBitmapIndexType
- doubleFieldBitmapIndex -> doubleFieldBitmapIndexType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
