kfaraz commented on code in PR #18870:
URL: https://github.com/apache/druid/pull/18870#discussion_r2658407773
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorResource.java:
##########
@@ -432,7 +432,7 @@ public Response handoffTaskGroups(
manager -> {
try {
if (manager.handoffTaskGroupsEarly(id, taskGroupIds)) {
- return Response.ok().build();
+ return Response.ok(Map.of("success", true)).build();
Review Comment:
Yeah, that makes sense. Let me update this.
I had to make this change since the current framework (the method
`EmbeddedServiceClient.onLeaderOverlord()`) was trying to deserialize the
response as a JSON value.
The empty/null entity was causing the deserialization to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
