kfaraz commented on code in PR #18766:
URL: https://github.com/apache/druid/pull/18766#discussion_r2671705719
##########
services/src/test/java/org/apache/druid/testing/embedded/EmbeddedClusterApis.java:
##########
@@ -353,6 +356,22 @@ public void
waitForAllSegmentsToBeAvailableWithCentralizedSchema(
);
}
+ /**
+ * Creates a waiter that can wait for a result to match a matcher. Make sure
to call {@link ResultWaiter#go()}
+ * or else the waiter will not do anything.
+ *
+ * In general, you should prefer using {@link LatchableEmitter} rather than
this method, because it doesn't need
+ * retry loops and is therefore both more responsive, and better at catching
race conditions. Use this method
+ * when there is no metric to wait on, and you believe that adding one would
be overkill.
+ */
+ public <T> ResultWaiter<T> waitForResult(
Review Comment:
Thanks for adding this and for the javadocs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
