capistrant commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2678335006
##########
server/src/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java:
##########
@@ -84,12 +88,16 @@ public DataSourceCompactibleSegmentIterator(
DataSourceCompactionConfig config,
SegmentTimeline timeline,
List<Interval> skipIntervals,
- CompactionCandidateSearchPolicy searchPolicy
+ CompactionCandidateSearchPolicy searchPolicy,
+ CompactionStateManager compactionStateManager,
+ CompactionStateCache compactionStateCache
Review Comment:
I put something out there for this. But something still seems off I think.
Like in the CompactionConfigBasedJobTemplate, it needs the
CompactionStateStorageImpl to be directly in the job params still because it
does an upsert. So I'm wondering if that method should also be exposed in this
interface so params only has to have the mapper? but then that leaks the upsert
to other places in the code which lost access to it as a part of this refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
