cryptoe commented on code in PR #18926: URL: https://github.com/apache/druid/pull/18926#discussion_r2706731692
########## multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java: ########## @@ -145,6 +145,7 @@ public class MultiStageQueryContext public static final String CTX_MAX_INPUT_BYTES_PER_WORKER = "maxInputBytesPerWorker"; public static final String CTX_MAX_INPUT_FILES_PER_WORKER = "maxInputFilesPerWorker"; public static final String CTX_MAX_PARTITIONS = "maxPartitions"; + public static final String CTX_MAX_CLUSTERED_BY_COLUMNS = "maxClusteredByColumns"; Review Comment: Nit: We add the dev documentation of context flags not released externally here : https://github.com/apache/druid/pull/18926/files#diff-5c9b518168571acb24b0a3c8c9e7213b960e839e38d105c148927a32fc64d65cL72 Also we might want to mention the motivation of this context parameter for code maintainability. I am really not sure if setting this in any prod workflows would be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
