GWphua commented on PR #18731: URL: https://github.com/apache/druid/pull/18731#issuecomment-3776374843
> My suggestion would be to split all the new max metrics into a separate PR: `mergeBuffer/maxAcquisitionTimeNs`, `groupBy/maxSpilledBytes`, `groupBy/maxMergeDictionarySize`. Those look more straightforward and would still be useful for operators to track. > > Then we can keep this PR and the linked issue open to track `mergeBuffer/bytesUsed` and `mergeBuffer/maxBytesUsed`. As suggested, moved 3 max metrics to #18934, leaving `maxBytesUsed` as the only max metric introduced in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
