Fly-Style commented on code in PR #18954:
URL: https://github.com/apache/druid/pull/18954#discussion_r2735419909
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1762,6 +1771,8 @@ public void runInternal()
checkTaskDuration();
+ maybeApplyPendingScaleRollover();
+
checkPendingCompletionTasks();
Review Comment:
`maybeApplyPendingScaleRollover` is gated only on
`activelyReadingTaskGroups` being empty, and it’s safe even if there are still
publishing tasks. Applying the `taskCount` change earlier (before you
prune/kill pending completion groups) ensures that the new allocation is staged
as soon as it’s safe and avoids extra cycles where you keep old `taskCount`
despite no active readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
