gianm commented on code in PR #18790: URL: https://github.com/apache/druid/pull/18790#discussion_r2748899824
########## docs/configuration/index.md: ########## @@ -2223,9 +2223,11 @@ context). If query does have `maxQueuedBytes` in the context, then that value is ### TopN query config +The `druid.query.topN.minTopNThreshold` configuration property has been deprecated. Use the `minTopNThreshold` query context parameter instead. Review Comment: This patch appears to remove it, not just deprecate it. I think it's fine, but the docs should be removed too, and a release note should be added. (Use the "Release notes" label and draft one in the PR description.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
