capistrant commented on code in PR #18939:
URL: https://github.com/apache/druid/pull/18939#discussion_r2819727362
##########
processing/src/main/java/org/apache/druid/segment/transform/CompactionTransformSpec.java:
##########
@@ -46,17 +47,20 @@ public static CompactionTransformSpec of(@Nullable
TransformSpec transformSpec)
return null;
}
- return new CompactionTransformSpec(transformSpec.getFilter());
+ return new CompactionTransformSpec(transformSpec.getFilter(), null);
}
@Nullable private final DimFilter filter;
+ @Nullable private final VirtualColumns virtualColumns;
@JsonCreator
public CompactionTransformSpec(
- @JsonProperty("filter") final DimFilter filter
+ @JsonProperty("filter") final DimFilter filter,
+ @JsonProperty("virtualColumns") final VirtualColumns virtualColumns
Review Comment:
one thought I guess is that CompcationTransformSpec actually just becomes a
baseTransformSpec with transforms that are ExpressionTransform? Just popped in
my head. I do want to try to avoid going down a path where we are using
something that is ok for now but needs changing eventually, cuz that would end
up changing the indexing state fingerprint and cause the supervisor to have to
re-process everything that used this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
