cecemei commented on code in PR #19059:
URL: https://github.com/apache/druid/pull/19059#discussion_r2862101726


##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/CompactionJobQueue.java:
##########
@@ -282,18 +283,20 @@ private boolean startJobIfPendingAndReady(
     }
 
     // Check if the job is already running, completed or skipped

Review Comment:
   actually i guess there's some logic change, the policy check has been moved 
to `CompactionConfigBasedJobTemplate` since creating the job needs to know the 
compaction mode (which is decided by the policy), but still the 
`computeCompactionStatus` only returns running/skipped/pending state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to