maytasm opened a new pull request, #19068:
URL: https://github.com/apache/druid/pull/19068
Fix flaky QueryVirtualStorageTest.testQueryTooMuchDataButWithDart
### Description
QueryVirtualStorageTest: handle null loadWait in DART report assertion
ChannelCounters.Snapshot.getLoadWait() is @Nullable — it returns null when
all values are zero, which can happens when
segment load wait time is sub-millisecond (the internal nanosecond value is
converted to milliseconds via
TimeUnit.NANOSECONDS.toMillis, truncating tiny waits to zero). On fast
machines (i.e. with a lot of cores) or when the executor has free threads, the
wait is effectively zero, causing a NullPointerException when the test accessed
getLoadWait()[0] unconditionally.
Updated the assertion to tolerate the null case, since zero wait time is a
legitimate outcome:
Assertions.assertTrue(
segmentChannelCounters.getLoadWait() == null
|| segmentChannelCounters.getLoadWait()[0] >= 0
);
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
