abhishekrb19 commented on code in PR #19069:
URL: https://github.com/apache/druid/pull/19069#discussion_r2875151681
##########
web-console/src/entry.tsx:
##########
@@ -70,6 +70,10 @@ interface ConsoleConfig {
// Allow for namespacing the local storage in case multiple clusters share a
URL due to proxying
localStorageNamespace?: string;
+
+ // Broker service name to use for all console SQL queries (for tier
isolation)
+ // This injects "brokerService" into the query context for routing via the
manual strategy
+ consoleBrokerService?: string;
Review Comment:
What do you think about exposing this config via `web-console-config.tsx` as
well? It has this dialog on the console, which seems cool:
<img width="1036" height="476" alt="Image"
src="https://github.com/user-attachments/assets/569f46e1-c592-4b26-ae82-022f523ea04d";
/>
I think `web-console-config.tsx` is session-based that stores config
overrides in the browser, while the `ConsoleConfig` from `console-config.js`
is persistent via the build. Not super familiar with the web-console code
here, so correct me if I'm missing something here.
Can `console-config.js` be overridden per environment, given that this file
is baked into the build as part of the source code?
##########
web-console/src/utils/druid-query.ts:
##########
@@ -322,13 +322,35 @@ export class DruidError extends Error {
}
}
+// Broker service to use for all console queries (for tier isolation)
+let consoleBrokerService: string | undefined;
+
+export function setConsoleBrokerService(brokerService: string | undefined):
void {
+ consoleBrokerService = brokerService;
+}
+
+export function getConsoleBrokerService(): string | undefined {
+ return consoleBrokerService;
+}
Review Comment:
Is this used anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
