GWphua commented on PR #19016: URL: https://github.com/apache/druid/pull/19016#issuecomment-3994848338
@kfaraz Thanks for letting me know, I will work on this after #19059 is merged. I have some concerns regarding the lock. Not sure if some of the things I enjoyed when using segmentLock will be preserved, answering these questions which will greatly help me understand things faster: 1. In an example of a interval having partitions [0, 10] and we have manually submitted 2 compaction task that compacts [0, 4] and [5, 8]. Will these 2 tasks be able to execute simultaneously, or will one task be blocked by the interval-wide lock? 2. I am assuming segmentId will be changed after upgrade here. Suppose compaction tasks submitted in (1) are now running, but we drafted a compaction task for segments [9, 10] based on the old segmentIds, and submitted it to Druid before the compaction tasks in (1) have completed. Will Druid run the task targeting the intended segments, or will it fail as the 'un-upgraded' segments [9,10] no longer exist? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
