capistrant commented on code in PR #19056:
URL: https://github.com/apache/druid/pull/19056#discussion_r2955706812
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java:
##########
@@ -163,9 +164,11 @@ public boolean hasNext() throws SocketTimeoutException
catch (RuntimeException ex) {
if (ex.getCause() instanceof SocketTimeoutException) {
throw (SocketTimeoutException) ex.getCause();
- } else {
- throw ex;
}
+ if (ex.getCause() instanceof StreamResetException) {
Review Comment:
this is still relying on an okhttp internal. Maybe we can just catch any
wrapped IOException and re-throw? then catch IOException in the discovery
provider after we catch the socket timeout. and log/return to force a re-list?
One fear is that is too heavy handed though as full list is expensive,
especially in clusters with lots of pods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
