jtuglu1 commented on code in PR #19236:
URL: https://github.com/apache/druid/pull/19236#discussion_r3052750564
##########
multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java:
##########
@@ -171,7 +172,13 @@ public QueryResponse<Object[]> runQuery(final DruidQuery
druidQuery)
taskContext
);
- FutureUtils.getUnchecked(overlordClient.runTask(taskId, controllerTask),
true);
+ // Propagate auth context headers to Overlord for consumption
+ if (plannerContext.getAuthenticationResult() != null &&
plannerContext.getAuthenticationResult().getContext() != null) {
Review Comment:
We need a way to propagate AuthenticationResult from the broker to the
overlord. I could make an overridable serialization method/class for
AuthenticationResult to ensure we only pass-through what's needed (and let the
user specify that), but propagating the headers here was the least intrusive
approach for that change. We still need to pass the authentication result
somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
