FrankChen021 commented on code in PR #19308:
URL: https://github.com/apache/druid/pull/19308#discussion_r3161339243
##########
pom.xml:
##########
@@ -1762,6 +1762,52 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>3.4.0</version>
+ <configuration>
+ <skip>${spotless.skip}</skip>
+ <java>
+ <excludes>
+ <exclude>**/extendedset/intset/**</exclude>
+ </excludes>
+ <cleanthat>
+ <version>2.25</version>
+ <sourceJdk>${maven.compiler.source}</sourceJdk>
Review Comment:
[P2] Use the Java 17 release for CleanThat
The new Spotless/CleanThat configuration uses `${maven.compiler.source}`,
which resolves from the Apache parent to `1.8`, while this repo compiles with
`${maven.compiler.release}` set to Java 17 and already contains Java 17 syntax
such as text blocks and records. Since Spotless runs during `validate` across
modules, CleanThat can parse/rewrite valid project sources as Java 8 or fail on
them, breaking normal builds. Point `sourceJdk` at `${maven.compiler.release}`
or `${java.version}` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
