GWphua commented on issue #19344: URL: https://github.com/apache/druid/issues/19344#issuecomment-4376201199
Appreciate the quick turnaround to this issue. > I would guess the aggregators are all probably also all checking isNull on their inputs which adds up, which I attempted to fix this once for simple numeric aggs for non-vectorized engines in https://github.com/apache/druid/pull/10666, though i never finished it and sort of forgot about it. We found that this is the cause of the regression. Will be working with @FrankChen021 to implement a fix for it. As for vectorization patch, I will take a look also after working on the non-vectorized patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
