GWphua commented on code in PR #19390:
URL: https://github.com/apache/druid/pull/19390#discussion_r3186494701
##########
processing/src/main/java/org/apache/druid/query/topn/TopNQueryEngine.java:
##########
@@ -172,7 +172,10 @@ private TopNMapFn getMapFn(
int numBytesPerRecord = 0;
for (AggregatorFactory aggregatorFactory : query.getAggregatorSpecs()) {
- numBytesPerRecord += aggregatorFactory.getMaxIntermediateSizeWithNulls();
+ numBytesPerRecord +=
PooledTopNAlgorithm.getMaxIntermediateSizeWithNullsForPooledTopN(
+ cursorInspector.getColumnInspector(),
+ aggregatorFactory
+ );
Review Comment:
Addressed in ff97b56 : Added tests to test the topN selection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
