clintropolis commented on issue #19408: URL: https://github.com/apache/druid/issues/19408#issuecomment-4383324824
>@cecemei @clintropolis @gianm is this worth delaying v37 release for a fix? hmm, this isn't probably a "new to this release" issue afaik, which is the only thing that should hold the release up at this point i think. The refactor that added the SegmentPruner abstraction is new, but the logic it was doing was previously present, just shuffled around by the refactor. I think for now we should fix by not letting a range filter participate in pruning if the match type is not string... i think this was an oversight on my part when I added this thing. The comment there is mostly aspirational about how someday I would like range partitioning to actually support partitioning on numeric and other type columns, correctly, using their native type comparators. I also think we should probably consider blocking range partitioning on numeric types for native batch in the first place the same way as MSQ does, since if you can't prune by something there seems little benefit to actually partitioning that way, and since we only really support lexicographic string partitioning right now there is unecessary room for error like this. However, that is a sort of breaking change since native batch does allow it, so I guess we might need some flag if people want to force it for some reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
