github-advanced-security[bot] commented on code in PR #19417:
URL: https://github.com/apache/druid/pull/19417#discussion_r3193932715
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java:
##########
@@ -422,6 +425,46 @@
Assert.assertFalse(runningSpec.isSuspended());
}
+ @Test
+ public void testTaskCountSerdeRoundTrip() throws IOException
+ {
+ // A persisted taskCount must survive a serialize/deserialize round-trip
even when
+ // autoScalerConfig.taskCountStart is set.
+ final CostBasedAutoScalerConfig autoScalerConfig =
+ CostBasedAutoScalerConfig.builder()
+ .enableTaskAutoScaler(true)
+ .taskCountMin(1)
+ .taskCountMax(100)
+ .taskCountStart(25)
+ .build();
+
+ final KafkaSupervisorSpec spec = new KafkaSupervisorSpecBuilder()
+ .withDataSchema(
+ schema -> schema
+ .withTimestamp(TimestampSpec.DEFAULT)
+ .withAggregators(new CountAggregatorFactory("rows"))
+ .withGranularity(new UniformGranularitySpec(Granularities.DAY,
Granularities.NONE, null))
+ )
+ .withIoConfig(
+ ioConfig -> ioConfig
+ .withJsonInputFormat()
+ .withConsumerProperties(Map.of("bootstrap.servers",
"localhost:9092"))
+ .withTaskCount(25)
+ .withAutoScalerConfig(autoScalerConfig)
+ .withLagAggregator(LagAggregator.DEFAULT)
+ )
+ .build("testDs", "metrics");
+
+ // Mutate taskCount the same way
SeekableStreamSupervisor.changeTaskCountInIOConfig does,
+ // and verify that the mutation is picked up by serialization.
+ spec.getIoConfig().setTaskCount(50);
+ final byte[] payload = mapper.writeValueAsBytes(spec);
+ final KafkaSupervisorSpec roundTripped =
+ (KafkaSupervisorSpec) mapper.readValue(payload, SupervisorSpec.class);
+ Assert.assertEquals(50, roundTripped.getIoConfig().getTaskCount());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [KafkaSupervisorSpec.getIoConfig](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11178)
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java:
##########
@@ -422,6 +425,46 @@
Assert.assertFalse(runningSpec.isSuspended());
}
+ @Test
+ public void testTaskCountSerdeRoundTrip() throws IOException
+ {
+ // A persisted taskCount must survive a serialize/deserialize round-trip
even when
+ // autoScalerConfig.taskCountStart is set.
+ final CostBasedAutoScalerConfig autoScalerConfig =
+ CostBasedAutoScalerConfig.builder()
+ .enableTaskAutoScaler(true)
+ .taskCountMin(1)
+ .taskCountMax(100)
+ .taskCountStart(25)
+ .build();
+
+ final KafkaSupervisorSpec spec = new KafkaSupervisorSpecBuilder()
+ .withDataSchema(
+ schema -> schema
+ .withTimestamp(TimestampSpec.DEFAULT)
+ .withAggregators(new CountAggregatorFactory("rows"))
+ .withGranularity(new UniformGranularitySpec(Granularities.DAY,
Granularities.NONE, null))
+ )
+ .withIoConfig(
+ ioConfig -> ioConfig
+ .withJsonInputFormat()
+ .withConsumerProperties(Map.of("bootstrap.servers",
"localhost:9092"))
+ .withTaskCount(25)
+ .withAutoScalerConfig(autoScalerConfig)
+ .withLagAggregator(LagAggregator.DEFAULT)
+ )
+ .build("testDs", "metrics");
+
+ // Mutate taskCount the same way
SeekableStreamSupervisor.changeTaskCountInIOConfig does,
+ // and verify that the mutation is picked up by serialization.
+ spec.getIoConfig().setTaskCount(50);
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [KafkaSupervisorSpec.getIoConfig](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11177)
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java:
##########
@@ -422,6 +425,46 @@
Assert.assertFalse(runningSpec.isSuspended());
}
+ @Test
+ public void testTaskCountSerdeRoundTrip() throws IOException
+ {
+ // A persisted taskCount must survive a serialize/deserialize round-trip
even when
+ // autoScalerConfig.taskCountStart is set.
+ final CostBasedAutoScalerConfig autoScalerConfig =
+ CostBasedAutoScalerConfig.builder()
+ .enableTaskAutoScaler(true)
+ .taskCountMin(1)
+ .taskCountMax(100)
+ .taskCountStart(25)
+ .build();
+
+ final KafkaSupervisorSpec spec = new KafkaSupervisorSpecBuilder()
+ .withDataSchema(
+ schema -> schema
+ .withTimestamp(TimestampSpec.DEFAULT)
+ .withAggregators(new CountAggregatorFactory("rows"))
+ .withGranularity(new UniformGranularitySpec(Granularities.DAY,
Granularities.NONE, null))
+ )
+ .withIoConfig(
+ ioConfig -> ioConfig
+ .withJsonInputFormat()
+ .withConsumerProperties(Map.of("bootstrap.servers",
"localhost:9092"))
+ .withTaskCount(25)
+ .withAutoScalerConfig(autoScalerConfig)
+ .withLagAggregator(LagAggregator.DEFAULT)
+ )
+ .build("testDs", "metrics");
+
+ // Mutate taskCount the same way
SeekableStreamSupervisor.changeTaskCountInIOConfig does,
+ // and verify that the mutation is picked up by serialization.
+ spec.getIoConfig().setTaskCount(50);
+ final byte[] payload = mapper.writeValueAsBytes(spec);
+ final KafkaSupervisorSpec roundTripped =
+ (KafkaSupervisorSpec) mapper.readValue(payload, SupervisorSpec.class);
+ Assert.assertEquals(50, roundTripped.getIoConfig().getTaskCount());
+ Assert.assertTrue(roundTripped.getIoConfig().isTaskCountExplicit());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [KafkaSupervisorSpec.getIoConfig](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11179)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
