pirvtech commented on code in PR #19392:
URL: https://github.com/apache/druid/pull/19392#discussion_r3197593141
##########
extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json:
##########
@@ -101,19 +101,33 @@
"segment/moved/bytes" : { "dimensions" : ["dataSource", "taskType"], "type"
: "count" },
"segment/nuked/bytes" : { "dimensions" : ["dataSource", "taskType"], "type"
: "count" },
- "segment/assigned/count" : { "dimensions" : ["tier"], "type" : "count" },
- "segment/moved/count" : { "dimensions" : ["tier"], "type" : "count" },
- "segment/dropped/count" : { "dimensions" : ["tier"], "type" : "count" },
- "segment/deleted/count" : { "dimensions" : ["tier"], "type" : "count" },
- "segment/unneeded/count" : { "dimensions" : ["tier"], "type" : "count" },
+ "segment/assigned/count" : { "dimensions" : ["dataSource", "tier"], "type" :
"count" },
+ "segment/moved/count" : { "dimensions" : ["dataSource", "tier"], "type" :
"count" },
+ "segment/dropped/count" : { "dimensions" : ["dataSource", "tier"], "type" :
"count" },
+ "segment/deleted/count" : { "dimensions" : ["dataSource"], "type" : "count"
},
+ "segment/unneeded/count" : { "dimensions" : ["dataSource", "tier"], "type" :
"count" },
"segment/unavailable/count" : { "dimensions" : ["dataSource"], "type" :
"gauge" },
"segment/underReplicated/count" : { "dimensions" : ["dataSource", "tier"],
"type" : "gauge" },
"segment/loadQueue/size" : { "dimensions" : ["server"], "type" : "gauge" },
- "segment/loadQueue/failed" : { "dimensions" : ["server"], "type" : "gauge" },
"segment/loadQueue/count" : { "dimensions" : ["server"], "type" : "gauge" },
"segment/dropQueue/count" : { "dimensions" : ["server"], "type" : "gauge" },
"segment/size" : { "dimensions" : ["dataSource"], "type" : "gauge" },
"segment/overShadowed/count" : { "dimensions" : [], "type" : "gauge" },
+ "segment/assignSkipped/count" : { "dimensions" : ["dataSource", "server",
"tier", "description"], "type" : "count" },
+ "segment/dropSkipped/count" : { "dimensions" : ["dataSource", "server",
"tier", "description"], "type" : "count" },
+ "segment/moveSkipped/count" : { "dimensions" : ["dataSource", "server",
"tier", "description"], "type" : "count" },
+
+ "segment/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
+ "segment/availableDeepStorageOnly/count" : { "dimensions" : ["dataSource"],
"type" : "gauge" },
+ "segment/unneededEternityTombstone/count" : { "dimensions" : ["dataSource"],
"type" : "gauge" },
+ "segment/clone/assigned/count" : { "dimensions" : ["dataSource"], "type" :
"count" },
+ "segment/clone/dropped/count" : { "dimensions" : ["dataSource"], "type" :
"count" },
Review Comment:
Fixed
##########
extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json:
##########
@@ -178,10 +192,18 @@
"tier/replication/factor" : { "dimensions" : ["tier"], "type" : "gauge" },
"tier/historical/count" : { "dimensions" : ["tier"], "type" : "count" },
+ "tier/storage/capacity" : { "dimensions" : ["tier"], "type" : "gauge" },
+ "tier/historical/clone/count" : { "dimensions" : ["tier"], "type" : "count"
},
+
"compact/task/count" : { "dimensions" : [], "type" : "count" },
"compactTask/maxSlot/count" : { "dimensions" : [], "type" : "count" },
"compactTask/availableSlot/count" : { "dimensions" : [], "type" : "count" },
+ "compact/createJobs/time" : { "dimensions" : [], "type" : "timer" },
+ "compact/createJobs/count" : { "dimensions" : [], "type" : "count" },
+ "compact/runScheduler/time" : { "dimensions" : [], "type" : "timer" },
+ "compactTask/cancelled/count" : { "dimensions" : [], "type" : "count" },
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
