gianm commented on code in PR #19423:
URL: https://github.com/apache/druid/pull/19423#discussion_r3199180299
##########
multi-stage-query/src/main/java/org/apache/druid/msq/querykit/groupby/GroupByPreShuffleFrameProcessor.java:
##########
@@ -193,8 +194,11 @@ protected ReturnOrAwait<Unit> runWithSegment(final
SegmentReferenceHolder segmen
rowSequence =
Sequences.simple(List.of(GroupByTimeBoundaryUtils.computeTimeBoundaryResult(query,
tbi)));
} else {
// Resolve this query using a cursor.
+ final GroupByQuery segmentQuery = (GroupByQuery) query
+ .withQuerySegmentSpec(new
SpecificSegmentSpec(segmentHolder.getDescriptor()))
+ .optimizeForSegment(new
PerSegmentQueryOptimizationContext(segmentHolder.getDescriptor()));
Review Comment:
I don't mind them being separate calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
