gianm commented on code in PR #19398:
URL: https://github.com/apache/druid/pull/19398#discussion_r3204068749
##########
processing/src/main/java/org/apache/druid/segment/projections/ProjectionMetadata.java:
##########
@@ -35,28 +37,60 @@ public class ProjectionMetadata
{
public static final Interner<ProjectionSchema> SCHEMA_INTERNER =
Interners.newWeakInterner();
- public static ProjectionMetadata forBaseTable(int numRows, List<String>
dims, Metadata metadata)
+ public static ProjectionMetadata forBaseTable(
+ int numRows,
+ @Nullable Long minTime,
+ @Nullable Long maxTime,
+ List<String> dims,
+ Metadata metadata
+ )
{
final ProjectionSchema schema;
if (Boolean.TRUE.equals(metadata.isRollup())) {
schema = RollupTableProjectionSchema.fromMetadata(dims, metadata);
} else {
schema = TableProjectionSchema.fromMetadata(dims, metadata);
}
- return new ProjectionMetadata(numRows, schema);
+ return new ProjectionMetadata(numRows, schema, minTime, maxTime);
}
private final int numRows;
private final ProjectionSchema schema;
+ /**
+ * Minimum {@code __time} value across all rows in this projection, or
{@code null} if the writer didn't supply one
Review Comment:
Comment seems overly verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
