FrankChen021 commented on code in PR #19428:
URL: https://github.com/apache/druid/pull/19428#discussion_r3208906895
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ThreadingTaskRunner.java:
##########
@@ -191,7 +191,8 @@ public TaskStatus call()
final File taskFile = new File(taskDir,
"task.json");
final File reportsFile = new File(attemptDir,
"report.json");
- final File logFile = new File(taskDir, "log");
+ final File logFile =
Review Comment:
[P2] Disabling task log files does not stop appenderator log routing
When druid.worker.useSeparateTaskLogFiles=false, the runner skips the task
log file here, but ingestion tasks that create appenderators can still install
per-task log routing through UnifiedIndexerAppenderatorsManager, whose override
unconditionally calls Appenderators.setTaskThreadContextForIndexers(taskId,
taskDirectory.getTaskLogFile(taskId)). BatchAppenderator and StreamAppenderator
invoke that override on persist/push/background executor paths, so those logs
can still be routed to per-task files instead of only the Indexer process log.
The new flag needs to be honored by the appenderator manager/override as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
