FrankChen021 commented on code in PR #19231:
URL: https://github.com/apache/druid/pull/19231#discussion_r3252855291
##########
sql/src/main/java/org/apache/druid/sql/PreparedStatement.java:
##########
@@ -31,14 +31,25 @@
public class PreparedStatement extends AbstractStatement
{
private final SqlQueryPlus originalRequest;
+ private final String remoteAddress;
public PreparedStatement(
final SqlToolbox lifecycleToolbox,
final SqlQueryPlus queryPlus
)
+ {
+ this(lifecycleToolbox, queryPlus, null);
+ }
+
+ public PreparedStatement(
+ final SqlToolbox lifecycleToolbox,
+ final SqlQueryPlus queryPlus,
+ final String remoteAddress
+ )
{
super(lifecycleToolbox, queryPlus, null);
Review Comment:
Confirmed, thanks. The current head forwards `remoteAddress` into the
`PreparedStatement` reporter via `super(...)`, and the prepared-statement test
now checks that every emitted prepared-statement log entry has a non-empty
remote address, so this thread looks resolved.
Reviewed 10 of 10 changed files.
---
This is an automated review by Codex GPT-5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
