github-advanced-security[bot] commented on code in PR #19486:
URL: https://github.com/apache/druid/pull/19486#discussion_r3271706871
##########
server/src/test/java/org/apache/druid/client/CachingClusteredClientTest.java:
##########
@@ -3132,27 +3132,94 @@
selector.addServerAndUpdateSegment(new QueryableDruidServer(servers[0],
null), dataSegment);
timeline.add(interval, "ver", new SingleElementPartitionChunk<>(selector));
- final TimeBoundaryQuery query = Druids.newTimeBoundaryQueryBuilder()
+ // include (default): historical segment is included
+ final TimeBoundaryQuery queryInclude = Druids.newTimeBoundaryQueryBuilder()
.dataSource(DATA_SOURCE)
.intervals(new
MultipleIntervalSegmentSpec(ImmutableList.of(queryInterval)))
- .context(ImmutableMap.of("realtimeSegmentsOnly", false))
+ .context(ImmutableMap.of(QueryContexts.REALTIME_SEGMENTS_MODE,
"include"))
.randomQueryId()
.build();
- final TimeBoundaryQuery query2 = Druids.newTimeBoundaryQueryBuilder()
+ // exclusive: only realtime segments — historical segment is excluded
+ final TimeBoundaryQuery queryExclusive =
Druids.newTimeBoundaryQueryBuilder()
+ .dataSource(DATA_SOURCE)
+ .intervals(new
MultipleIntervalSegmentSpec(ImmutableList.of(queryInterval)))
+ .context(ImmutableMap.of(QueryContexts.REALTIME_SEGMENTS_MODE,
"exclusive"))
+ .randomQueryId()
+ .build();
+
+ // backward compat: realtimeSegmentsOnly=true maps to EXCLUSIVE
+ final TimeBoundaryQuery queryLegacyTrue =
Druids.newTimeBoundaryQueryBuilder()
.dataSource(DATA_SOURCE)
.intervals(new
MultipleIntervalSegmentSpec(ImmutableList.of(queryInterval)))
- .context(ImmutableMap.of("realtimeSegmentsOnly", true))
+ .context(ImmutableMap.of(QueryContexts.REALTIME_SEGMENTS_ONLY,
true))
.randomQueryId()
.build();
final ResponseContext responseContext = initializeResponseContext();
- getDefaultQueryRunner().run(QueryPlus.wrap(query), responseContext);
- getDefaultQueryRunner().run(QueryPlus.wrap(query2), responseContext);
+ getDefaultQueryRunner().run(QueryPlus.wrap(queryInclude), responseContext);
+ getDefaultQueryRunner().run(QueryPlus.wrap(queryExclusive),
responseContext);
+ getDefaultQueryRunner().run(QueryPlus.wrap(queryLegacyTrue),
responseContext);
+
+ final Map<String, Integer> remainingResponseMap = (Map<String, Integer>)
responseContext.get(ResponseContext.Keys.REMAINING_RESPONSES_FROM_QUERY_SERVERS);
+ Assert.assertEquals(1,
remainingResponseMap.get(queryInclude.getId()).intValue());
+ Assert.assertEquals(0,
remainingResponseMap.get(queryExclusive.getId()).intValue());
+ Assert.assertEquals(0,
remainingResponseMap.get(queryLegacyTrue.getId()).intValue());
+ }
+
+ @Test
+ public void testRealtimeSegmentsModeExclude()
+ {
+ final Interval interval = Intervals.of("2016-01-01/2016-01-02");
+ final Interval queryInterval =
Intervals.of("2016-01-01T14:00:00/2016-01-02T14:00:00");
+ final DataSegment dataSegment = new DataSegment(
+ "dataSource",
+ interval,
+ "ver",
+ ImmutableMap.of("type", "hdfs", "path", "/tmp"),
+ ImmutableList.of("product"),
+ ImmutableList.of("visited_sum"),
+ NoneShardSpec.instance(),
+ 9,
+ 12334
+ );
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [DataSegment.DataSegment](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11241)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
