capistrant commented on code in PR #19494:
URL: https://github.com/apache/druid/pull/19494#discussion_r3283754306
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -473,6 +471,10 @@ public AcquireSegmentAction acquireSegment(final
DataSegment dataSegment)
return acquireExisting;
}
+ if (!config.isVirtualStorage()) {
+ return AcquireSegmentAction.missingSegment();
+ }
Review Comment:
this feels off topic, can you provide some context? this also seems to make
lines 486 to 488 below dead code, if it is indeed safe to hoist this block up
out of the synchronized block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
