FrankChen021 commented on code in PR #19514:
URL: https://github.com/apache/druid/pull/19514#discussion_r3298113265
##########
processing/src/main/java/org/apache/druid/data/input/impl/RegexInputFormat.java:
##########
@@ -56,7 +60,7 @@ public RegexInputFormat(
this.pattern = pattern;
this.listDelimiter = listDelimiter;
this.columns = columns;
- this.compiledPatternSupplier = Suppliers.memoize(() ->
Pattern.compile(pattern));
+ this.compiledPatternSupplier = Suppliers.memoize(() ->
RegexPatternFactory.compile(regexConfig.getEngine(), pattern));
Review Comment:
[P2] Regex engine config is not wired into all ingestion runtimes
`RegexInputFormat` now depends on injected `RegexConfig`, but the module
that binds the configured engine is not installed in every ingestion runtime
that deserializes this type, such as standalone indexer and sampler/overlord
paths. In those paths Guice can fall back to the default Java engine, so
`druid.regex.engine=RE2J` is silently ignored and the ReDoS mitigation does not
cover supported ingestion flows. Please install the regex engine module
wherever input formats are materialized, or otherwise ensure this constructor
receives the configured engine in those runtimes.
##########
docs/ingestion/data-formats.md:
##########
@@ -897,7 +965,8 @@ This query returns:
|---------------------|-----------------|
| `1680795276351` | `partition-1` |
-## FlattenSpec
+## Flat
Review Comment:
[P3] Restore the FlattenSpec heading
This heading was split into `## Flat` and `tenSpec`, so the rendered docs no
longer expose the `FlattenSpec` section title or the existing `#flattenspec`
anchor. Please restore the single `## FlattenSpec` heading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
