kgyrtkirk commented on PR #19465: URL: https://github.com/apache/druid/pull/19465#issuecomment-4873959698
I think this PR could have used some more reviews... the PR description states that the issue was that `pull` was counted into some timeout... the fix is very fragile - as it hard codes some versions into an yml file into an inline script... instead of bending the CI to pull random images with fixed versions some alternate should have been explored like to modifiy the java code to separate the pull from the spin up somehow - so in the future if we upgrade versions or in need of different docker images it will still work... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
