clintropolis opened a new pull request, #19671:
URL: https://github.com/apache/druid/pull/19671

   ### Description
   This PR finishes the partial load rules by wiring the partial load specs up 
to the segment cache, allowing historicals in virtual storage mode to eagerly 
load and pin parts of segments to the cache, while allowing the rest of the 
segment to still be loaded on demand (and evicted). This PR works by storing 
partial segment cache entries as weak entries, but with an additional 'rule' 
hold on all parts that are specified by a partial load rule/spec. It takes an 
imo nicer approach than #19657 which tried to store the rule specified bundles 
as 'static' cache entries and added a lot of additional complexity for 
transitions for rule changes.
   
   changes:
   * partial load rules/specs are now wired up to the segment cache when 
virtual storage mode and partial loads are enabled, allowing eager loading of 
parts of segments which are pinned in the cache until dropped
   * when under a partial load spec, partial segment cache entries are still 
added to the cache as weak entries, but with an additional set of 'rule' holds 
on all required bundles
   * partial load spec changes operate on a delta, dropping the rule holds for 
bundles no longer pinned, and loading and adding new rule holds on things which 
should be pinned
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to