github-advanced-security[bot] commented on code in PR #19231:
URL: https://github.com/apache/druid/pull/19231#discussion_r3587499735
##########
sql/src/main/java/org/apache/druid/sql/avatica/DruidJdbcStatement.java:
##########
@@ -57,11 +58,17 @@
this.lifecycleFactory = Preconditions.checkNotNull(lifecycleFactory,
"lifecycleFactory");
}
- public synchronized void execute(SqlQueryPlus queryPlus, long maxRowCount)
+ /**
+ * Executes the given query. The {@code remoteAddress} is read from the
calling
+ * (execute) request rather than captured when the statement was created, so
that
+ * a statement reused after a reconnect or from a different remote is
attributed
+ * to the actual caller of this execution.
+ */
+ public synchronized void execute(SqlQueryPlus queryPlus, long maxRowCount,
@Nullable String remoteAddress)
Review Comment:
## CodeQL / Useless parameter
The parameter 'maxRowCount' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11341)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
