gianm commented on code in PR #19772:
URL: https://github.com/apache/druid/pull/19772#discussion_r3661340936
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/duty/UnusedSegmentsKillerTest.java:
##########
@@ -200,37 +200,31 @@ public void test_run_launchesEmbeddedKillTasks_ifLeader()
);
}
- @Test
- public void test_maxSegmentsKilledInAnInterval_is_1k()
+ @Test(timeout = 30_000L)
+ public void test_maxSegmentsKilledInRun_is_200k()
Review Comment:
On my machine this test legitimately takes nearly 30s to run, which has two
problems:
- The `timeout = 30_000L` is low enough that it would make the test flaky
- 30s is just generally a long time.
Is it possible to change the test to run faster while still being effective?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
