kfaraz commented on code in PR #19772:
URL: https://github.com/apache/druid/pull/19772#discussion_r3685210414
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/duty/UnusedSegmentsKiller.java:
##########
@@ -361,7 +421,27 @@ private void runKillTask(KillCandidate candidate, String
taskId)
}
finally {
cleanupLocksSilently(killTask);
- emitMetric(Metric.PROCESSED_KILL_JOBS, 1L,
Map.of(DruidMetrics.DATASOURCE, candidate.dataSource));
+ emitMetric(Metric.PROCESSED_KILL_JOBS, 1L,
Map.of(DruidMetrics.DATASOURCE, candidate.dataSource()));
+ }
+ }
+
+ private boolean shouldUseConcurrentLocks(Map<String, Object> context)
+ {
+ if (context == null) {
+ return DEFAULT_USE_CONCURRENT_LOCKS;
+ }
+
+ final Boolean useConcurrentLocksOverride = (Boolean)
context.get(Tasks.USE_CONCURRENT_LOCKS);
Review Comment:
Thanks for the suggestion! Fixed.
Moved the common code to `TaskLocks`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
