Copilot commented on code in PR #19814: URL: https://github.com/apache/druid/pull/19814#discussion_r3686689566
########## .github/scripts/web-checks.sh: ########## @@ -23,7 +23,7 @@ mvn -B com.github.eirslett:frontend-maven-plugin:install-node-and-npm@install-no PATH+=:web-console/target/node/ # docs -(cd website && npm install) +(cd website && npm ci) Review Comment: The PR description says `website/package-lock.json` was regenerated with the repository-pinned npm `10.8.2`, but this script runs `npm ci` using the npm that was installed via `frontend-maven-plugin` for `web-console` (currently `npm.version` is `10.9.0`). To keep CI reproducible and aligned with the pinned npm version, run the install step via `npx --yes [email protected] ci` (as in the PR validation steps) or otherwise ensure the npm version used here matches the pinned one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
