FrankChen021 commented on PR #19754: URL: https://github.com/apache/druid/pull/19754#issuecomment-5140331357
@sklochkov Thank you for submitting this PR. I know it was a huge effort to migrate netty 3 to netty 4 even under the help from Claude models. Because there're two PRs doing the SAME thing, I think we need to discuss which one should be the preferred one so that we can move on and do not waste any human and AI resources. Above, I asked the Codex to compare these two implementations and generated a comparison. This is just a reference for our reference. Previous Codex auto review reported no findings, but the summary says: '_it introduces additional behavioral changes despite stating a zero-behavior-change goal._'. I don't know this, maybe we need more clarifications from AI. And the another concern the summary raised is about the dependency downgrade which is also reported by current pipeline. @clintropolis what's your opinion on these two migration implementations? Disclosure: This is a human written comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
