github-advanced-security[bot] commented on code in PR #19845:
URL: https://github.com/apache/druid/pull/19845#discussion_r3690050438
##########
multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQInsertTest.java:
##########
@@ -879,6 +890,128 @@
.verifyResults();
}
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
+ public void
testInsertOnExternalDataSourceWithUnsealedCatalogClusteredBaseTable(
+ String contextName,
+ Map<String, Object> context
+ ) throws IOException
+ {
+ final File toRead = getResourceAsTemporaryFile("/wikipedia-sampled.json");
+ final String toReadFileNameAsJson =
queryFramework().queryJsonMapper().writeValueAsString(toRead.getAbsolutePath());
+
+ // The table declares only channel, __time and delta. The other four
columns the query produces are appended after
+ // them in query output order, so the declared layout (clustering prefix,
time position) is unchanged and nothing
+ // the query selected is dropped.
+ RowSignature rowSignature = RowSignature.builder()
+ .add("channel", ColumnType.STRING)
+ .add("__time", ColumnType.LONG)
+ .add("delta", ColumnType.LONG)
+ .add("page", ColumnType.STRING)
+ .add("user", ColumnType.STRING)
+ .add("added", ColumnType.LONG)
+ .add("deleted", ColumnType.LONG)
+ .build();
+
+ testIngestQuery().setSql(" insert into fooClusteredUnsealed SELECT\n"
+ + " floor(TIME_PARSE(\"timestamp\") to minute)
AS __time,\n"
+ + " channel,\n"
+ + " page,\n"
+ + " user,\n"
+ + " added,\n"
+ + " deleted,\n"
+ + " delta\n"
+ + "FROM TABLE(\n"
+ + " EXTERN(\n"
+ + " '{ \"files\": [" + toReadFileNameAsJson +
"],\"type\":\"local\"}',\n"
+ + " '{\"type\": \"json\"}',\n"
+ + " '[{\"name\": \"timestamp\", \"type\":
\"string\"}, {\"name\": \"channel\", \"type\": \"string\"}, {\"name\":
\"page\", \"type\": \"string\"}, {\"name\": \"user\", \"type\": \"string\"},
{\"name\": \"added\", \"type\": \"long\"}, {\"name\": \"deleted\", \"type\":
\"long\"}, {\"name\": \"delta\", \"type\": \"long\"}]'\n"
+ + " )\n"
+ + ") PARTITIONED by day ")
+ .setExpectedDataSource("fooClusteredUnsealed")
+ .setExpectedRowSignature(rowSignature)
+ .setQueryContext(context)
+ .setExpectedSegments(ImmutableSet.of(SegmentId.of(
+ "fooClusteredUnsealed",
+ Intervals.of("2016-06-27/P1D"),
+ "test",
+ 0
+ )))
+ // The appended columns are not clustered on; clustering
is what the table declared.
+ .setExpectedClusterGroups(
+ new ClusterGroupTuples(
+ RowSignature.builder().add("channel",
ColumnType.STRING).build(),
+ ImmutableList.of(
+ ImmutableList.of("#ceb.wikipedia"),
+ ImmutableList.of("#de.wikipedia"),
+ ImmutableList.of("#en.wikipedia"),
+ ImmutableList.of("#es.wikipedia"),
+ ImmutableList.of("#id.wikipedia"),
+ ImmutableList.of("#pl.wikipedia"),
+ ImmutableList.of("#pt.wikipedia"),
+ ImmutableList.of("#ru.wikipedia"),
+ ImmutableList.of("#sh.wikipedia"),
+ ImmutableList.of("#sv.wikipedia"),
+ ImmutableList.of("#zh.wikipedia")
+ )
+ )
+ )
+ // Rows are read back in segment order, which now sorts
by delta ahead of the appended columns.
+ .setExpectedResultRows(
+ ImmutableList.of(
+ new Object[]{"#ceb.wikipedia", 1466985660000L,
4150L, "Neqerssuaq", "Lsjbot", 4150L, 0L},
+ new Object[]{"#de.wikipedia", 1466992920000L,
2560L, "Benutzer Diskussion:Squasher/Archiv/2016", "TaxonBot", 2560L, 0L},
+ new Object[]{"#de.wikipedia", 1466992980000L,
364L, "Benutzer Diskussion:HerrSonderbar", "GiftBot", 364L, 0L},
+ new Object[]{"#en.wikipedia", 1466985600000L,
-2L, "Richie Rich's Christmas Wish", "JasonAQuest", 0L, 2L},
+ new Object[]{"#en.wikipedia", 1466985600000L, 2L,
"Bailando 2015", "181.230.118.178", 2L, 0L},
+ new Object[]{"#en.wikipedia", 1466985660000L,
496L, "Panama Canal", "Mariordo", 496L, 0L},
+ new Object[]{"#en.wikipedia", 1466992980000L,
-463L, "File:Paint.net 4.0.6 screenshot.png", "Calvin Hogg", 0L, 463L},
+ new Object[]{"#es.wikipedia", 1466985660000L,
-173L, "Sumo (banda)", "181.110.165.189", 0L, 173L},
+ new Object[]{"#es.wikipedia", 1466989320000L, 4L,
"Clasificación para la Eurocopa Sub-21 de 2017", "Guly600", 4L, 0L},
+ new Object[]{"#id.wikipedia", 1466989320000L,
106L, "Ibnu Sina", "Ftihikam", 106L, 0L},
+ new Object[]{"#pl.wikipedia", 1466985600000L,
270L, "Kategoria:Dyskusje nad usunięciem artykułu zakończone bez konsensusu −
lipiec 2016", "Beau.bot", 270L, 0L},
+ new Object[]{"#pt.wikipedia", 1466992920000L,
1926L, "Dobromir Zhechev", "Ceresta", 1926L, 0L},
+ new Object[]{"#ru.wikipedia", 1466985720000L,
196L, "Википедия:Опросы/Унификация шаблонов «Не переведено»", "Wanderer777",
196L, 0L},
+ new Object[]{"#sh.wikipedia", 1466985660000L,
-1L, "El Terco, Bachíniva", "Kolega2357", 0L, 1L},
+ new Object[]{"#sh.wikipedia", 1466985720000L,
-1L, "Hermanos Díaz, Ascensión", "Kolega2357", 0L, 1L},
+ new Object[]{"#sh.wikipedia", 1466989320000L,
-1L, "El Sicomoro, Ascensión", "Kolega2357", 0L, 1L},
+ new Object[]{"#sh.wikipedia", 1466992920000L,
-1L, "Trinidad Jiménez G., Benemérito de las Américas", "Kolega2357", 0L, 1L},
+ new Object[]{"#sv.wikipedia", 1466985600000L,
31L, "Salo Toraut", "Lsjbot", 31L, 0L},
+ new Object[]{"#zh.wikipedia", 1466989320000L,
18L, "中共十八大以来的反腐败工作", "2001:DA8:207:E132:94DC:BA03:DFDF:8F9F", 18L, 0L},
+ new Object[]{"#zh.wikipedia", 1466992920000L,
1986L, "Wikipedia:頁面存廢討論/記錄/2016/06/27", "Tigerzeng", 1986L, 0L}
+ )
+ )
+ .verifyResults();
+ }
+
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
+ public void testInsertOnUnsealedCatalogClusteredBaseTableUnstorableColumn(
+ String contextName,
Review Comment:
## CodeQL / Useless parameter
The parameter 'contextName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11453)
##########
multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQInsertTest.java:
##########
@@ -879,6 +890,128 @@
.verifyResults();
}
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
+ public void
testInsertOnExternalDataSourceWithUnsealedCatalogClusteredBaseTable(
+ String contextName,
Review Comment:
## CodeQL / Useless parameter
The parameter 'contextName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11454)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
