FrankChen021 commented on code in PR #19822:
URL: https://github.com/apache/druid/pull/19822#discussion_r3698047201
##########
processing/src/test/java/org/apache/druid/segment/IndexMergerV9WithSpatialIndexTest.java:
##########
@@ -513,10 +510,7 @@ private static QueryableIndex makeMergedQueryableIndex(
}
finally {
- FileUtils.deleteDirectory(firstFile);
- FileUtils.deleteDirectory(secondFile);
- FileUtils.deleteDirectory(thirdFile);
- FileUtils.deleteDirectory(mergedFile);
+ FileUtils.deleteDirectory(tmpFile);
Review Comment:
Fixed in `51114329ab` and pushed. `makeQueryableIndex` and
`makeMergedQueryableIndex` now keep their mapped backing files available with
`deleteOnExit()` instead of deleting the temporary roots in `finally`, so
returned indexes remain usable across platforms. Focused
`IndexMergerV9WithSpatialIndexTest` passed (36 tests), and Maven Checkstyle/PMD
validation passed. Reviewed 34 of 34 changed files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
