FrankChen021 opened a new pull request, #19857: URL: https://github.com/apache/druid/pull/19857
## Summary Make `IncrementalIndexCursorFactoryTest.testSanity` independent of result sequence order. `GroupingEngine.process` returns the raw grouped sequence and does not apply the query's `ORDER BY` post-processing. When the incremental index is not sorted by dimensions, positional assertions on the returned rows are not valid. ## Evidence The original failure occurred in the JDK 25 unit-test shard: - [Failed CI job](https://github.com/apache/druid/actions/runs/30748065218/job/91497026107) - Failing case: `testSanity[1: onheap, sortByDim: false]` - Failure: expected the row beginning with `null`, but received the row beginning with `hi` Before this change, the focused test was run 10 times locally on JDK 25 and reproduced the same failure twice. This confirms that the failure is nondeterministic rather than a deterministic assertion failure. ## Changes Replace positional row assertions with order-independent assertions while retaining validation of both expected result rows. ## Tests - Focused parameterized class: 16 tests, 0 failures, 1 skipped - Focused `testSanity` repeated 10 times on JDK 25 after the change: 10/10 passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
