FrankChen021 commented on code in PR #19875:
URL: https://github.com/apache/druid/pull/19875#discussion_r3714581914
##########
extensions-core/testing-tools/src/test/java/org/apache/druid/guice/ClusterTestingModuleTest.java:
##########
@@ -87,7 +86,7 @@ public void
test_peonRunnable_isNotModified_ifTestingIsDisabled() throws IOExcep
System.setProperty("druid.unsafe.cluster.testing", "false");
// Write out the task payload in a temporary json file
- File file = temporaryFolder.newFile("task.json");
+ File file = File.createTempFile("task.json", null, temporaryFolder);
Review Comment:
[P1] Preserve the required task.json filename
`File.createTempFile("task.json", null, temporaryFolder)` creates a
randomized name such as `task.json123.tmp`, while `CliPeon` reads
`<taskDir>/task.json`. These tests therefore miss the task payload and fail
before exercising the cluster-testing configuration. Create `new
File(temporaryFolder, "task.json")` instead, and fix all four converted
occurrences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
