FrankChen021 commented on code in PR #19878: URL: https://github.com/apache/druid/pull/19878#discussion_r3714584575
########## extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java: ########## @@ -138,10 +138,14 @@ import java.util.concurrent.CopyOnWriteArrayList; import java.util.concurrent.Executor; import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; import java.util.function.Function; import java.util.stream.Collectors; -@RunWith(Parameterized.class) +import static org.junit.jupiter.api.Assertions.assertThrows; + +@ParameterizedClass Review Comment: [P1] Restore all Kafka supervisor test annotations The migration adds `@ParameterizedClass` but removes all 70 `@Test` annotations. `@ParameterizedClass` parameterizes the class container; it does not turn unannotated methods into tests, and `@Timeout` alone is not a test annotation. This silently drops the entire Kafka supervisor suite. Import Jupiter's `Test` and retain `@Test` on every migrated test method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
