FrankChen021 commented on issue #13948:
URL: https://github.com/apache/druid/issues/13948#issuecomment-5185284398
### Remaining work after the extensions-core JUnit 5 migration
The seven extensions-core migration PRs (#19875–#19881) convert the module
test classes, but the dependency graph shows these follow-ups:
1. **Migrate shared processing test fixtures**
-
`processing/src/test/java/org/apache/druid/segment/filter/BaseFilterTest.java`
still uses JUnit 4 `TemporaryFolder`, `@Rule`, `@Before`, and `Parameterized`.
The migrated `BloomDimFilterTest` still depends on this fixture.
-
`processing/src/test/java/org/apache/druid/query/aggregation/AggregationTestHelper.java`
still contains legacy `TemporaryFolder` overloads. Its JUnit 5-compatible
temp-directory overloads are transitional.
2. **Remove transitional dependencies after those fixtures and callers are
migrated**
- `junit:junit`
- `junit-vintage-engine`
- `junit-jupiter-migrationsupport`
- Any Hamcrest dependency that is no longer directly required.
3. **Retire migration tooling only after the repository-wide migration is
complete**
- Remove the OpenRewrite Maven plugin and `rewrite.yml`.
- Remove `dev/validate-junit5-usage`, or replace it with a permanent
JUnit 5-only guard.
- Update `.github/scripts/create-jacoco-coverage-report.sh`, which
currently invokes that validation script.
4. **Perform a final repository-wide audit**
- Confirm no JUnit 4 imports, `TemporaryFolder`, Vintage engine, or
migration-support dependencies remain where they are no longer needed.
- Run the affected tests plus Maven Checkstyle and FindBugs/SpotBugs
static checks.
Recommended order: extensions-core migration PRs → processing fixture
migration → remove transitional dependencies → final audit → remove OpenRewrite
and temporary guardrails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
