FrankChen021 commented on code in PR #19704:
URL: https://github.com/apache/druid/pull/19704#discussion_r3720545205
##########
processing/src/main/java/org/apache/druid/timeline/partition/DimensionValueSetShardSpec.java:
##########
@@ -89,6 +125,11 @@ public boolean possibleInDomain(Map<String,
RangeSet<String>> domain)
final String dimension = entry.getKey();
final List<String> allowedValues = entry.getValue();
+ if (dimensionColumnTypes.containsKey(dimension)) {
Review Comment:
[P2] Keep null pruning for stamped numeric dimensions
LONG-stamped dimensions unconditionally skip `possibleInDomain`, but
`NullFilter` only supplies that range domain and does not implement
`getDimensionValueSet`. Consequently, `IS NULL` retains every LONG segment,
including segments whose stamped values contain no null, despite this PR's
numeric null-pruning coverage. Preserve null-only range pruning for stamped
dimensions or add a typed null-domain representation and a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
