FrankChen021 commented on code in PR #19815:
URL: https://github.com/apache/druid/pull/19815#discussion_r3720928891
##########
web-console/webpack.config.mjs:
##########
@@ -58,7 +58,7 @@ export default env => {
const plugins = [
new webpack.DefinePlugin({
'process.env': JSON.stringify({ NODE_ENV: mode }),
- 'global': {},
+ 'global': 'globalThis',
Review Comment:
Addressed in 6483f343a2. A raw entry banner initializes `globalThis.global`
before modules execute, and DefinePlugin now maps `global` to the assignable
`globalThis.global` property. This preserves both property access and
assignment semantics. `npm run compile` passed, the built entry begins with the
shim, and `npm run test-unit` passed all 158 suites / 785 tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
