sakshichitnis27 commented on PR #19858: URL: https://github.com/apache/druid/pull/19858#issuecomment-5193759161
@FrankChen021 Thanks for catching this. I pushed a follow-up fix in d7d6f3b25a. The timeout path no longer waits indefinitely for executor termination. Cache disposal is queued behind the Kafka worker on the same single-thread executor, so start() can return false after the timeout while the cache remains available until the worker has actually stopped using it. I also updated the regression test to verify that: - start() returns while an uninterruptible poll is still blocked; - the cache is not disposed prematurely; and - cleanup completes after the worker exits. Locally, all 18 KafkaLookupExtractorFactoryTest tests pass, including five consecutive full-class runs, along with Checkstyle, PMD, Maven Enforcer, forbidden-API checks, and compilation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
