capistrant opened a new pull request, #19892: URL: https://github.com/apache/druid/pull/19892
### Description AWS sdk has made changes to how s3 retries are handled by the client. There are multiple policy decisions available. https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html can be referenced for more information. The biggest change in this PR is ensuring that we are operating with STANDARD which is the general recommendation for policy going forward. ADAPTIVE is the special case policy that I want to expose to operators. We do update docs to suggest that ingestion tasks may be good fits for adaptive but we do not go as far as changing the policy for anything to use adaptive by default. If we find that it is far and away better, perhaps future releases will create clients with policies tailored to the job of the service. #### Release note Explicitly change to the AWS Standard retry policy for the s3 client. The retry mode used by s3 client is configurable now in case operators want to customize. One such customization that may be useful is moving `druid.s3.retryMode` to adaptive for ingestion tasks. Operators should use caution when making changes the the retry mode, and consult https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html before making any decisions for critical service configuration. <hr> ##### Key changed/added classes in this PR * `AWSClientConfig` * `ServerSideEncryptingAmazonS3` <hr> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
