FrankChen021 commented on PR #19875: URL: https://github.com/apache/druid/pull/19875#issuecomment-5207769234
Addressed both `AggregationTestHelper` review points in `98ee1b2f50`: 1. **Public method names/API:** Good catch. I restored the original `create*(..., TemporaryFolder)` overload names and reverted the PR-only `.getRoot()` caller changes. Jupiter callers use the clearly named `*WithTempDir(..., File)` overloads. Keeping the original lazy `TemporaryFolder.newFolder()` path is necessary: constructor-time callers fail with `IllegalStateException: temporary folder has not yet been created` if they eagerly call `getRoot()` before the rule lifecycle starts. 2. **`GroupByQueryRunnerTestHelper` class:** This change is necessary for the JUnit 5 cleanup. Loading `GroupByQueryRunnerTest` after removing direct JUnit 4 dependencies produced `NoClassDefFoundError: org/junit/rules/ExternalResource`. `GroupByQueryRunnerTestHelper` provides the same factory setup without loading a JUnit 4 test class. The affected processing, DataSketches, Histogram, and Stats suites pass with this separation. I also completed the requested Hamcrest audit: no direct Hamcrest source usage remains in extensions-core, including the seven specifically flagged tests. Kafka/Kinesis/Catalog continue to retain JUnit 4 for the shared inherited fixtures described in the PR body; their JUnit declarations are intentionally unchanged in this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
